offline_items_collection : Added helper class to determine progress

chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.download.ui;
 
 import android.content.Context;
 import android.content.res.ColorStateList;
 import android.graphics.Bitmap;
 import android.text.TextUtils;
 import android.text.format.Formatter;
 import android.util.AttributeSet;
 import android.view.View;
 import android.widget.LinearLayout;
 import android.widget.TextView;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.download.DownloadUtils;
 import org.chromium.chrome.browser.widget.MaterialProgressBar;
 import org.chromium.chrome.browser.widget.TintedImageButton;
 import org.chromium.chrome.browser.widget.TintedImageView;
 import org.chromium.chrome.browser.widget.selection.SelectableItemView;
+import org.chromium.components.offline_items_collection.OfflineItem.Progress;
 import org.chromium.ui.UiUtils;
 
 /**
  * The view for a downloaded item displayed in the Downloads list.
  */
 public class DownloadItemView extends SelectableItemView<DownloadHistoryItemWrapper>
         implements ThumbnailProvider.ThumbnailRequest {
     private final int mMargin;
     private final int mIconBackgroundColor;
     private final int mIconBackgroundColorSelected;
@@ skipping 123 matching lines @@
         mHostnameView.setText(item.getDisplayHostname());
         mFilesizeView.setText(
                 Formatter.formatFileSize(context, item.getFileSize()));
 
         if (item.isComplete()) {
             showLayout(mLayoutCompleted);
         } else {
             showLayout(mLayoutInProgress);
             mDownloadStatusView.setText(item.getStatusString());
 
-            boolean isIndeterminate = item.isIndeterminate();
+            Progress progress = item.getDownloadProgress();
 
             if (item.isPaused()) {
                 mPauseResumeButton.setImageResource(R.drawable.ic_play_arrow_white_24dp);
                 mPauseResumeButton.setContentDescription(
                         getContext().getString(R.string.download_notification_resume_button));
                 mProgressView.setIndeterminate(false);
             } else {
                 mPauseResumeButton.setImageResource(R.drawable.ic_pause_white_24dp);
                 mPauseResumeButton.setContentDescription(
                         getContext().getString(R.string.download_notification_pause_button));
-                mProgressView.setIndeterminate(isIndeterminate);
+                mProgressView.setIndeterminate(progress.isIndeterminate());
             }
-            mProgressView.setProgress(item.getDownloadProgress());
+
+            if (!progress.isIndeterminate()) {
+                mProgressView.setProgress(progress.getPercentage());
+            }
 
             // Display the percentage downloaded in text form.
             // To avoid problems with RelativeLayout not knowing how to place views relative to
             // removed views in the hierarchy, this code instead makes the percentage View's width
             // to 0 by removing its text and eliminating the margin.
-            if (isIndeterminate) {
+            if (progress.isIndeterminate()) {
                 mDownloadPercentageView.setText(null);
                 ApiCompatibilityUtils.setMarginEnd(
                         (MarginLayoutParams) mDownloadPercentageView.getLayoutParams(), 0);
             } else {
                 mDownloadPercentageView.setText(

[David Trainor- moved to gerrit, 2017/05/09 05:36:01]

Should we add a TODO and file a bug to investigate showing more detailed
information here?

[shaktisahu, 2017/05/09 19:04:32]

I didn't get it. We are just showing the percentage here. 

-                        DownloadUtils.getPercentageString(item.getDownloadProgress()));
+                        DownloadUtils.getPercentageString(progress.getPercentage()));
                 ApiCompatibilityUtils.setMarginEnd(
                         (MarginLayoutParams) mDownloadPercentageView.getLayoutParams(), mMargin);
             }
         }
 
         setBackgroundResourceForGroupPosition(
                 getItem().isFirstInGroup(), getItem().isLastInGroup());
     }
 
     /**
@@ skipping 46 matching lines @@
         if (mLayoutInProgress != layoutToShow) UiUtils.removeViewFromParent(mLayoutInProgress);
 
         if (layoutToShow.getParent() == null) {
             LinearLayout.LayoutParams params =
                     new LinearLayout.LayoutParams(0, LayoutParams.WRAP_CONTENT);
             params.weight = 1;
             mLayoutContainer.addView(layoutToShow, params);
         }
     }
 }