Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2861783002: fix more mixin tests to work in strong mode (Closed)

Created:
3 years, 7 months ago by Jennifer Messerly
Modified:
3 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -91 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 2 chunks +2 lines, -19 lines 0 comments Download
M pkg/dev_compiler/tool/run.js View 1 chunk +7 lines, -1 line 0 comments Download
M tests/language_strong/mixin_extends_field_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_strong/mixin_extends_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/mixin_field_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_strong/mixin_lib_extends_field_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_strong/mixin_lib_extends_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/mixin_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/mixin_super_bound_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language_strong/mixin_super_constructor2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/mixin_super_constructor_default_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language_strong/mixin_super_constructor_named_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language_strong/mixin_super_constructor_positionals_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language_strong/mixin_super_constructor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language_strong/mixin_type_parameter4_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_strong/mixin_type_parameters_mixin_extends_test.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M tests/language_strong/mixin_type_parameters_mixin_test.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M tests/language_strong/mixin_type_parameters_simple_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language_strong/mixin_type_parameters_super_extends_test.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M tests/language_strong/mixin_type_parameters_super_test.dart View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
I'm not sure if any of these cover https://github.com/dart-lang/sdk/issues/29544, but I wanted to enable what ...
3 years, 7 months ago (2017-05-03 17:11:26 UTC) #3
vsm
lgtm
3 years, 7 months ago (2017-05-04 14:26:48 UTC) #4
Jennifer Messerly
3 years, 7 months ago (2017-05-04 18:30:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6ab17db3daa46f818c7d0fdcdfd85a901807956c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698