third_party/WebKit/Source/core/layout/LayoutTable.cpp - Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)

Patch Set: shend@'s suggestions Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTable.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.cpp b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

index e7dfbd5d600d8bd73e9b0dd773b26d280807bc38..41c3d05011de6cfa6eee51659284b878039422e6 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTable.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

@@ -1697,7 +1697,7 @@ LayoutTable* LayoutTable::CreateAnonymousWithParent(

return new_table;

}

-const BorderValue& LayoutTable::TableStartBorderAdjoiningCell(

+BorderValue LayoutTable::TableStartBorderAdjoiningCell(

const LayoutTableCell* cell) const {

#if DCHECK_IS_ON()

DCHECK(cell->IsFirstOrLastCellInRow());

@@ -1708,7 +1708,7 @@ const BorderValue& LayoutTable::TableStartBorderAdjoiningCell(

return Style()->BorderEnd();

}

-const BorderValue& LayoutTable::TableEndBorderAdjoiningCell(

+BorderValue LayoutTable::TableEndBorderAdjoiningCell(

const LayoutTableCell* cell) const {

#if DCHECK_IS_ON()

DCHECK(cell->IsFirstOrLastCellInRow());