third_party/WebKit/Source/build/scripts/make_computed_style_base.py - Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)

Patch Set: shend@'s suggestions Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl » ('j') | third_party/WebKit/Source/core/style/BorderValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

index 6a09efd58e3ad98dbdc999d2f507b3dbd9e55e05..a181350f4317cdd9e5071746d0333e3497525437 100755

--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

@@ -349,8 +349,6 @@ class ComputedStyleBaseWriter(make_style_builder.StyleBuilderWriter):

for property_ in css_properties:

# All CSS properties that are generated do not have custom comparison and copy logic.

property_['has_custom_compare_and_copy'] = False

- # CSS properties are not allowed to explicitly specify their field_size.

- property_['field_size'] = None

# Read extra fields using the parameter specification from the CSS properties file.

extra_fields = json5_generator.Json5File.load_from_files(