third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)

Patch Set: Change border-*-width from a float to unsigned Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index dbf533cd0cb10eed0c1323ae9409b1a2c23b8edd..76de0966b1db2f518a408d7002cdb319225572b1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -338,7 +338,7 @@ void LayoutBox::StyleDidChange(StyleDifference diff,

// The overflow clip paint property depends on border sizes through

// overflowClipRect(), and border radii, so we update properties on

// border size or radii change.

- if (!old_style->Border().SizeEquals(new_style.Border()) ||

+ if (!old_style->BorderSizeEquals(new_style) ||

!old_style->RadiiEqual(new_style))

SetNeedsPaintPropertyUpdate();

}