Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)
Patch Set: Change border-*-width from a float to unsigned Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
index b772c04b72b73452db4e884edd2083f41b03a0e5..c160194b507692db2924bacf85fd0a4a95e56e13 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
@@ -1964,7 +1964,15 @@ bool StyleResolver::HasAuthorBorder(const StyleResolverState& state) {
cached_ua_style->bottom_left_ ==
state.Style()->BorderBottomLeftRadius() &&
cached_ua_style->bottom_right_ ==
- state.Style()->BorderBottomRightRadius()));
+ state.Style()->BorderBottomRightRadius()) ||
+ (cached_ua_style->border_left_width !=
shend 2017/05/07 23:08:30 nit: I would move this up to just after line 1959,
nainar 2017/05/08 00:59:57 Done.
+ state.Style()->BorderLeftWidth() ||
+ cached_ua_style->border_right_width !=
+ state.Style()->BorderRightWidth() ||
+ cached_ua_style->border_top_width !=
+ state.Style()->BorderTopWidth() ||
+ cached_ua_style->border_bottom_width !=
+ state.Style()->BorderBottomWidth()));
}
void StyleResolver::ApplyCallbackSelectors(StyleResolverState& state) {

Powered by Google App Engine
This is Rietveld 408576698