third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl - Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)

Patch Set: Change border-*-width from a float to unsigned Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('k') | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('j') | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

index 22a1a3e0f6d320a8e512b5d4cbbce49033ac4315..3bcd4386a1e7e4efba2f01ea68daced067f4a953 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

@@ -12,7 +12,7 @@ struct SameSizeAsComputedStyleBase {

void* dataRefs[{{computed_style.subgroups|length}}];

{% endif %}

{% for field in computed_style.fields|rejectattr("is_bit_field") %}

- {{field.type_name}} {{field.name}}};

+ {{field.type_name}} {{field.name}};

nainar 2017/05/05 07:16:49 Cleaning up an erroneous bracket. This code was ne

shend 2017/05/07 23:08:30 Nice catch!

{% endfor %}

unsigned m_bit_fields[{{computed_style.num_32_bit_words_for_bit_fields}}];

};