Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.h

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)
Patch Set: meade@'s suggestion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCell.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.h b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
index f4208542fed419266ece076861f544d6afa89af6..c8c73433a76314a1da8844fd24d26e2815d96c4f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
@@ -251,7 +251,7 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
// direction on all table parts and writing-mode on cells.
const ComputedStyle& StyleForCellFlow() const { return Row()->StyleRef(); }
- const BorderValue& BorderAdjoiningTableStart() const {
+ BorderValue BorderAdjoiningTableStart() const {
#if DCHECK_IS_ON()
DCHECK(IsFirstOrLastCellInRow());
#endif
@@ -261,7 +261,7 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
return Style()->BorderEnd();
}
- const BorderValue& BorderAdjoiningTableEnd() const {
+ BorderValue BorderAdjoiningTableEnd() const {
#if DCHECK_IS_ON()
DCHECK(IsFirstOrLastCellInRow());
#endif
@@ -271,14 +271,14 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
return Style()->BorderStart();
}
- const BorderValue& BorderAdjoiningCellBefore(const LayoutTableCell* cell) {
+ BorderValue BorderAdjoiningCellBefore(const LayoutTableCell* cell) {
DCHECK_EQ(Table()->CellAfter(cell), this);
// FIXME: https://webkit.org/b/79272 - Add support for mixed directionality
// at the cell level.
return Style()->BorderStart();
}
- const BorderValue& BorderAdjoiningCellAfter(const LayoutTableCell* cell) {
+ BorderValue BorderAdjoiningCellAfter(const LayoutTableCell* cell) {
DCHECK_EQ(Table()->CellBefore(cell), this);
// FIXME: https://webkit.org/b/79272 - Add support for mixed directionality
// at the cell level.

Powered by Google App Engine
This is Rietveld 408576698