Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.h

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)
Patch Set: meade@'s suggestion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights
8 * reserved. 8 * reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 : total_rows_height(0), 194 : total_rows_height(0),
195 spanning_cell_height_ignoring_border_spacing(0), 195 spanning_cell_height_ignoring_border_spacing(0),
196 is_any_row_with_only_spanning_cells(false) {} 196 is_any_row_with_only_spanning_cells(false) {}
197 197
198 Vector<int> row_height; 198 Vector<int> row_height;
199 int total_rows_height; 199 int total_rows_height;
200 int spanning_cell_height_ignoring_border_spacing; 200 int spanning_cell_height_ignoring_border_spacing;
201 bool is_any_row_with_only_spanning_cells; 201 bool is_any_row_with_only_spanning_cells;
202 }; 202 };
203 203
204 const BorderValue& BorderAdjoiningTableStart() const { 204 BorderValue BorderAdjoiningTableStart() const {
205 if (HasSameDirectionAs(Table())) 205 if (HasSameDirectionAs(Table()))
206 return Style()->BorderStart(); 206 return Style()->BorderStart();
207 207
208 return Style()->BorderEnd(); 208 return Style()->BorderEnd();
209 } 209 }
210 210
211 const BorderValue& BorderAdjoiningTableEnd() const { 211 BorderValue BorderAdjoiningTableEnd() const {
212 if (HasSameDirectionAs(Table())) 212 if (HasSameDirectionAs(Table()))
213 return Style()->BorderEnd(); 213 return Style()->BorderEnd();
214 214
215 return Style()->BorderStart(); 215 return Style()->BorderStart();
216 } 216 }
217 217
218 const BorderValue& BorderAdjoiningStartCell(const LayoutTableCell*) const; 218 BorderValue BorderAdjoiningStartCell(const LayoutTableCell*) const;
219 const BorderValue& BorderAdjoiningEndCell(const LayoutTableCell*) const; 219 BorderValue BorderAdjoiningEndCell(const LayoutTableCell*) const;
220 220
221 const LayoutTableCell* FirstRowCellAdjoiningTableStart() const; 221 const LayoutTableCell* FirstRowCellAdjoiningTableStart() const;
222 const LayoutTableCell* FirstRowCellAdjoiningTableEnd() const; 222 const LayoutTableCell* FirstRowCellAdjoiningTableEnd() const;
223 223
224 CellStruct& CellAt(unsigned row, unsigned effective_column) { 224 CellStruct& CellAt(unsigned row, unsigned effective_column) {
225 return grid_[row].row[effective_column]; 225 return grid_[row].row[effective_column];
226 } 226 }
227 const CellStruct& CellAt(unsigned row, unsigned effective_column) const { 227 const CellStruct& CellAt(unsigned row, unsigned effective_column) const {
228 return grid_[row].row[effective_column]; 228 return grid_[row].row[effective_column];
229 } 229 }
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 503
504 // Whether any cell spans multiple rows or cols. 504 // Whether any cell spans multiple rows or cols.
505 bool has_spanning_cells_; 505 bool has_spanning_cells_;
506 }; 506 };
507 507
508 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableSection, IsTableSection()); 508 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableSection, IsTableSection());
509 509
510 } // namespace blink 510 } // namespace blink
511 511
512 #endif // LayoutTableSection_h 512 #endif // LayoutTableSection_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableRow.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698