Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)
Patch Set: meade@'s suggestion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013
8 * Apple Inc. 8 * Apple Inc.
9 * All rights reserved. 9 * All rights reserved.
10 * 10 *
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 // Most table componenents can rely on LayoutObject::styleDidChange 91 // Most table componenents can rely on LayoutObject::styleDidChange
92 // to mark the container chain dirty. But LayoutTableSection seems 92 // to mark the container chain dirty. But LayoutTableSection seems
93 // to never clear its dirty bit, which stops the propagation. So 93 // to never clear its dirty bit, which stops the propagation. So
94 // anything under LayoutTableSection has to restart the propagation 94 // anything under LayoutTableSection has to restart the propagation
95 // at the table. 95 // at the table.
96 // TODO(dgrogan): Make LayoutTableSection clear its dirty bit. 96 // TODO(dgrogan): Make LayoutTableSection clear its dirty bit.
97 table->SetPreferredLogicalWidthsDirty(); 97 table->SetPreferredLogicalWidthsDirty();
98 } 98 }
99 } 99 }
100 100
101 const BorderValue& LayoutTableRow::BorderAdjoiningStartCell( 101 BorderValue LayoutTableRow::BorderAdjoiningStartCell(
102 const LayoutTableCell* cell) const { 102 const LayoutTableCell* cell) const {
103 #if DCHECK_IS_ON() 103 #if DCHECK_IS_ON()
104 DCHECK(cell->IsFirstOrLastCellInRow()); 104 DCHECK(cell->IsFirstOrLastCellInRow());
105 #endif 105 #endif
106 // FIXME: https://webkit.org/b/79272 - Add support for mixed directionality at 106 // FIXME: https://webkit.org/b/79272 - Add support for mixed directionality at
107 // the cell level. 107 // the cell level.
108 return Style()->BorderStart(); 108 return Style()->BorderStart();
109 } 109 }
110 110
111 const BorderValue& LayoutTableRow::BorderAdjoiningEndCell( 111 BorderValue LayoutTableRow::BorderAdjoiningEndCell(
112 const LayoutTableCell* cell) const { 112 const LayoutTableCell* cell) const {
113 #if DCHECK_IS_ON() 113 #if DCHECK_IS_ON()
114 DCHECK(cell->IsFirstOrLastCellInRow()); 114 DCHECK(cell->IsFirstOrLastCellInRow());
115 #endif 115 #endif
116 // FIXME: https://webkit.org/b/79272 - Add support for mixed directionality at 116 // FIXME: https://webkit.org/b/79272 - Add support for mixed directionality at
117 // the cell level. 117 // the cell level.
118 return Style()->BorderEnd(); 118 return Style()->BorderEnd();
119 } 119 }
120 120
121 void LayoutTableRow::AddChild(LayoutObject* child, LayoutObject* before_child) { 121 void LayoutTableRow::AddChild(LayoutObject* child, LayoutObject* before_child) {
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 // won't fit but we avoid the complexity of that reading until it 326 // won't fit but we avoid the complexity of that reading until it
327 // is clarified. Tracked by crbug.com/675904 327 // is clarified. Tracked by crbug.com/675904
328 if (RowIndex()) 328 if (RowIndex())
329 return false; 329 return false;
330 LayoutTableSection* header = Table()->Header(); 330 LayoutTableSection* header = Table()->Header();
331 return header && Table()->SectionAbove(Section()) == header && 331 return header && Table()->SectionAbove(Section()) == header &&
332 header->GetPaginationBreakability() != kAllowAnyBreaks; 332 header->GetPaginationBreakability() != kAllowAnyBreaks;
333 } 333 }
334 334
335 } // namespace blink 335 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableRow.h ('k') | third_party/WebKit/Source/core/layout/LayoutTableSection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698