Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)
Patch Set: meade@'s suggestion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 if (flow_thread && flow_thread != this) 331 if (flow_thread && flow_thread != this)
332 flow_thread->FlowThreadDescendantStyleDidChange(this, diff, *old_style); 332 flow_thread->FlowThreadDescendantStyleDidChange(this, diff, *old_style);
333 333
334 UpdateScrollSnapMappingAfterStyleChange(&new_style, old_style); 334 UpdateScrollSnapMappingAfterStyleChange(&new_style, old_style);
335 335
336 if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && 336 if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() &&
337 ShouldClipOverflow()) { 337 ShouldClipOverflow()) {
338 // The overflow clip paint property depends on border sizes through 338 // The overflow clip paint property depends on border sizes through
339 // overflowClipRect(), and border radii, so we update properties on 339 // overflowClipRect(), and border radii, so we update properties on
340 // border size or radii change. 340 // border size or radii change.
341 if (!old_style->Border().SizeEquals(new_style.Border()) || 341 if (!old_style->BorderSizeEquals(new_style) ||
342 !old_style->RadiiEqual(new_style)) 342 !old_style->RadiiEqual(new_style))
343 SetNeedsPaintPropertyUpdate(); 343 SetNeedsPaintPropertyUpdate();
344 } 344 }
345 } 345 }
346 346
347 if (diff.TransformChanged()) { 347 if (diff.TransformChanged()) {
348 if (ScrollingCoordinator* scrolling_coordinator = 348 if (ScrollingCoordinator* scrolling_coordinator =
349 GetDocument().GetFrame()->GetPage()->GetScrollingCoordinator()) 349 GetDocument().GetFrame()->GetPage()->GetScrollingCoordinator())
350 scrolling_coordinator->NotifyTransformChanged(*this); 350 scrolling_coordinator->NotifyTransformChanged(*this);
351 } 351 }
(...skipping 5552 matching lines...) Expand 10 before | Expand all | Expand 10 after
5904 void LayoutBox::MutableForPainting:: 5904 void LayoutBox::MutableForPainting::
5905 SavePreviousContentBoxSizeAndLayoutOverflowRect() { 5905 SavePreviousContentBoxSizeAndLayoutOverflowRect() {
5906 auto& rare_data = GetLayoutBox().EnsureRareData(); 5906 auto& rare_data = GetLayoutBox().EnsureRareData();
5907 rare_data.has_previous_content_box_size_and_layout_overflow_rect_ = true; 5907 rare_data.has_previous_content_box_size_and_layout_overflow_rect_ = true;
5908 rare_data.previous_content_box_size_ = GetLayoutBox().ContentBoxRect().Size(); 5908 rare_data.previous_content_box_size_ = GetLayoutBox().ContentBoxRect().Size();
5909 rare_data.previous_layout_overflow_rect_ = 5909 rare_data.previous_layout_overflow_rect_ =
5910 GetLayoutBox().LayoutOverflowRect(); 5910 GetLayoutBox().LayoutOverflowRect();
5911 } 5911 }
5912 5912
5913 } // namespace blink 5913 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698