Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSProperties.json5

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)
Patch Set: meade@'s suggestion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 // This file specifies all the CSS properties we support and the necessary 2 // This file specifies all the CSS properties we support and the necessary
3 // information for our code generation. The various supported arguments 3 // information for our code generation. The various supported arguments
4 // are described below with example usage 4 // are described below with example usage
5 5
6 parameters: { 6 parameters: {
7 // - alias_for: "other-property" 7 // - alias_for: "other-property"
8 // Properties specifying alias_for should be virtually identical to the 8 // Properties specifying alias_for should be virtually identical to the
9 // properties they alias. Minor parsing differences are allowed as long as 9 // properties they alias. Minor parsing differences are allowed as long as
10 // the CSSValues created are of the same format of the aliased property. 10 // the CSSValues created are of the same format of the aliased property.
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 }, 62 },
63 63
64 // - field_group 64 // - field_group
65 // Name of the group that this field belongs to. Fields in the same group ar e stored 65 // Name of the group that this field belongs to. Fields in the same group ar e stored
66 // together as a nested class inside ComputedStyle and dynamically allocated on use. 66 // together as a nested class inside ComputedStyle and dynamically allocated on use.
67 // Leave this out if the field is stored directly on ComputedStyle. 67 // Leave this out if the field is stored directly on ComputedStyle.
68 field_group: { 68 field_group: {
69 value_type: "str" 69 value_type: "str"
70 }, 70 },
71 71
72 // - field_size
73 // Number of bits needed to store this field. Only used for storage_only
74 // fields. If specified, the field will be stored as bit field. Otherwise
75 // it will be stored as a normal data member.
76 field_size: {
77 valid_type: "int",
78 },
79
72 // - field_template 80 // - field_template
73 // Affects how the interface to this field is generated. 81 // Affects how the interface to this field is generated.
74 // TODO(sashab, meade): Remove this once TypedOM types are specified for 82 // TODO(sashab, meade): Remove this once TypedOM types are specified for
75 // every property, since this value can be inferred from that. 83 // every property, since this value can be inferred from that.
76 field_template: { 84 field_template: {
77 valid_values: [ 85 valid_values: [
78 // Field is stored as an enum and has a initial/getter/setter/resetter. 86 // Field is stored as an enum and has a initial/getter/setter/resetter.
79 "keyword", 87 "keyword",
80 // Field stores a primitive value like int/bool. The type is specified b y 88 // Field stores a primitive value like int/bool. The type is specified b y
81 // type_name. The interface has a initial/getter/setter/resetter. 89 // type_name. The interface has a initial/getter/setter/resetter.
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
675 typedom_types: ["Image"], 683 typedom_types: ["Image"],
676 }, 684 },
677 { 685 {
678 name: "border-bottom-width", 686 name: "border-bottom-width",
679 api_class: "CSSPropertyAPIBorderWidth", 687 api_class: "CSSPropertyAPIBorderWidth",
680 converter: "ConvertLineWidth<float>", 688 converter: "ConvertLineWidth<float>",
681 initial: "InitialBorderWidth", 689 initial: "InitialBorderWidth",
682 interpolable: true, 690 interpolable: true,
683 keywords: ["thin", "medium", "thick"], 691 keywords: ["thin", "medium", "thick"],
684 typedom_types: ["Length"], 692 typedom_types: ["Length"],
693 field_template: "storage_only",
694 type_name: "unsigned",
695 field_size : 26,
696 default_value: "WidthToFixedPoint(3)",
697 field_group: "surround",
685 }, 698 },
686 { 699 {
687 name: "border-collapse", 700 name: "border-collapse",
688 independent: true, 701 independent: true,
689 inherited: true, 702 inherited: true,
690 default_value: "separate", 703 default_value: "separate",
691 field_template: "keyword", 704 field_template: "keyword",
692 keywords: ["separate", "collapse"], 705 keywords: ["separate", "collapse"],
693 }, 706 },
694 { 707 {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 typedom_types: ["Image"], 749 typedom_types: ["Image"],
737 }, 750 },
738 { 751 {
739 name: "border-left-width", 752 name: "border-left-width",
740 api_class: "CSSPropertyAPIBorderWidth", 753 api_class: "CSSPropertyAPIBorderWidth",
741 converter: "ConvertLineWidth<float>", 754 converter: "ConvertLineWidth<float>",
742 initial: "InitialBorderWidth", 755 initial: "InitialBorderWidth",
743 interpolable: true, 756 interpolable: true,
744 keywords: ["thin", "medium", "thick"], 757 keywords: ["thin", "medium", "thick"],
745 typedom_types: ["Length"], 758 typedom_types: ["Length"],
759 field_template: "storage_only",
760 type_name: "unsigned",
761 field_size : 26,
762 default_value: "WidthToFixedPoint(3)",
763 field_group: "surround",
746 }, 764 },
747 { 765 {
748 name: "border-right-color", 766 name: "border-right-color",
749 custom_all: true, 767 custom_all: true,
750 interpolable: true, 768 interpolable: true,
751 }, 769 },
752 { 770 {
753 name: "border-right-style", 771 name: "border-right-style",
754 initial: "InitialBorderStyle", 772 initial: "InitialBorderStyle",
755 type_name: "EBorderStyle", 773 type_name: "EBorderStyle",
756 keywords: ["none"], 774 keywords: ["none"],
757 typedom_types: ["Image"], 775 typedom_types: ["Image"],
758 }, 776 },
759 { 777 {
760 name: "border-right-width", 778 name: "border-right-width",
761 api_class: "CSSPropertyAPIBorderWidth", 779 api_class: "CSSPropertyAPIBorderWidth",
762 converter: "ConvertLineWidth<float>", 780 converter: "ConvertLineWidth<float>",
763 initial: "InitialBorderWidth", 781 initial: "InitialBorderWidth",
764 interpolable: true, 782 interpolable: true,
765 keywords: ["thin", "medium", "thick"], 783 keywords: ["thin", "medium", "thick"],
766 typedom_types: ["Length"], 784 typedom_types: ["Length"],
785 field_template: "storage_only",
786 type_name: "unsigned",
787 field_size : 26,
788 default_value: "WidthToFixedPoint(3)",
789 field_group: "surround",
767 }, 790 },
768 { 791 {
769 name: "border-top-color", 792 name: "border-top-color",
770 custom_all: true, 793 custom_all: true,
771 interpolable: true, 794 interpolable: true,
772 }, 795 },
773 { 796 {
774 name: "border-top-left-radius", 797 name: "border-top-left-radius",
775 api_class: "CSSPropertyAPIBorderRadius", 798 api_class: "CSSPropertyAPIBorderRadius",
776 api_methods: ["parseSingleValue"], 799 api_methods: ["parseSingleValue"],
(...skipping 24 matching lines...) Expand all
801 }, 824 },
802 { 825 {
803 name: "border-top-width", 826 name: "border-top-width",
804 api_class: "CSSPropertyAPIBorderWidth", 827 api_class: "CSSPropertyAPIBorderWidth",
805 converter: "ConvertLineWidth<float>", 828 converter: "ConvertLineWidth<float>",
806 initial: "InitialBorderWidth", 829 initial: "InitialBorderWidth",
807 interpolable: true, 830 interpolable: true,
808 keywords: ["thin", "medium", "thick"], 831 keywords: ["thin", "medium", "thick"],
809 supports_percentage: true, 832 supports_percentage: true,
810 typedom_types: ["Length"], 833 typedom_types: ["Length"],
834 field_template: "storage_only",
835 type_name: "unsigned",
836 field_size : 26,
837 default_value: "WidthToFixedPoint(3)",
838 field_group: "surround",
811 }, 839 },
812 { 840 {
813 name: "bottom", 841 name: "bottom",
814 api_class: "CSSPropertyAPIMargin", 842 api_class: "CSSPropertyAPIMargin",
815 api_methods: ["parseSingleValue"], 843 api_methods: ["parseSingleValue"],
816 converter: "ConvertLengthOrAuto", 844 converter: "ConvertLengthOrAuto",
817 interpolable: true, 845 interpolable: true,
818 keywords: ["auto"], 846 keywords: ["auto"],
819 supports_percentage: true, 847 supports_percentage: true,
820 typedom_types: ["Length"], 848 typedom_types: ["Length"],
(...skipping 2408 matching lines...) Expand 10 before | Expand all | Expand 10 after
3229 { 3257 {
3230 name: "-webkit-transition-timing-function", 3258 name: "-webkit-transition-timing-function",
3231 alias_for: "transition-timing-function", 3259 alias_for: "transition-timing-function",
3232 }, 3260 },
3233 { 3261 {
3234 name: "-webkit-user-select", 3262 name: "-webkit-user-select",
3235 alias_for: "user-select", 3263 alias_for: "user-select",
3236 }, 3264 },
3237 ], 3265 ],
3238 } 3266 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698