Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

Issue 2861773004: Move border-*-width out of BorderValue and store on SurroundData in ComputedStyle instead (Closed)
Patch Set: meade@'s suggestion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% from 'macros.tmpl' import license %} 1 {% from 'macros.tmpl' import license %}
2 {% from 'fields/field.tmpl' import getter_expression, setter_expression, fieldwi se_copy, fieldwise_diff %} 2 {% from 'fields/field.tmpl' import getter_expression, setter_expression, fieldwi se_copy, fieldwise_diff %}
3 {{license()}} 3 {{license()}}
4 4
5 #include "core/ComputedStyleBase.h" 5 #include "core/ComputedStyleBase.h"
6 #include "platform/wtf/SizeAssertions.h" 6 #include "platform/wtf/SizeAssertions.h"
7 7
8 namespace blink { 8 namespace blink {
9 9
10 struct SameSizeAsComputedStyleBase { 10 struct SameSizeAsComputedStyleBase {
11 {% if computed_style.subgroups is defined %} 11 {% if computed_style.subgroups is defined %}
12 void* dataRefs[{{computed_style.subgroups|length}}]; 12 void* dataRefs[{{computed_style.subgroups|length}}];
13 {% endif %} 13 {% endif %}
14 {% for field in computed_style.fields|rejectattr("is_bit_field") %} 14 {% for field in computed_style.fields|rejectattr("is_bit_field") %}
15 {{field.type_name}} {{field.name}}}; 15 {{field.type_name}} {{field.name}};
16 {% endfor %} 16 {% endfor %}
17 unsigned m_bit_fields[{{computed_style.num_32_bit_words_for_bit_fields}}]; 17 unsigned m_bit_fields[{{computed_style.num_32_bit_words_for_bit_fields}}];
18 }; 18 };
19 19
20 // If this fails, the packing algorithm in make_computed_style_base.py has 20 // If this fails, the packing algorithm in make_computed_style_base.py has
21 // failed to produce the optimal packed size. To fix, update the algorithm to 21 // failed to produce the optimal packed size. To fix, update the algorithm to
22 // ensure that the buckets are placed so that each takes up at most 1 word. 22 // ensure that the buckets are placed so that each takes up at most 1 word.
23 ASSERT_SIZE(ComputedStyleBase, SameSizeAsComputedStyleBase); 23 ASSERT_SIZE(ComputedStyleBase, SameSizeAsComputedStyleBase);
24 24
25 void ComputedStyleBase::InheritFrom(const ComputedStyleBase& other, 25 void ComputedStyleBase::InheritFrom(const ComputedStyleBase& other,
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 bool ComputedStyleBase::DiffNeedsFullLayoutAndPaintInvalidation( 61 bool ComputedStyleBase::DiffNeedsFullLayoutAndPaintInvalidation(
62 const ComputedStyleBase& other) const { 62 const ComputedStyleBase& other) const {
63 {{fieldwise_diff(computed_style, computed_style.all_fields 63 {{fieldwise_diff(computed_style, computed_style.all_fields
64 |selectattr("property_name", "in", ["padding-top", "padding-left", "paddin g-right", "padding-bottom"]) 64 |selectattr("property_name", "in", ["padding-top", "padding-left", "paddin g-right", "padding-bottom"])
65 |list 65 |list
66 )|indent(2)}} 66 )|indent(2)}}
67 return false; 67 return false;
68 } 68 }
69 69
70 } // namespace blink 70 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698