Issue 2861733002: Handle const Symbol(...) in kernel_impact

Issue 2861733002: Handle const Symbol(...) in kernel_impact (Closed)

Created:
3 years, 7 months ago by Johnni Winther

Modified:
3 years, 7 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Handle const Symbol(...) in kernel_impact This includes moving towards using ConstantValue instead of ConstantExpression in ElementAdapter and friends. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/add1d2723a1d6e1190f2f65d057f8171d453b520

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -53 lines)			Patch
M	pkg/compiler/lib/src/kernel/element_adapter.dart	View	6 chunks	+21 lines, -12 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map.dart	View	9 chunks	+13 lines, -17 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/native_basic_data.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/native/behavior.dart	View	10 chunks	+12 lines, -19 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_impact.dart	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/kernel/closed_world2_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/kernel/impact_test.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 7 months ago (2017-05-04 08:28:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
add1d2723a1d6e1190f2f65d057f8171d453b520 (presubmit successful).