Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: chrome/browser/resources/print_preview/settings/settings_section_select.js

Issue 2861713004: Print Preview: Fix compile errors in settings/ directory (Closed)
Patch Set: Address comments and fix remaining lint errors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/settings_section_select.js
diff --git a/chrome/browser/resources/print_preview/settings/settings_section_select.js b/chrome/browser/resources/print_preview/settings/settings_section_select.js
index 0799c94e1c0c200160bd45daf236c0bd71275e45..713c950ebec9413a7244832dda0708c05d72d5e2 100644
--- a/chrome/browser/resources/print_preview/settings/settings_section_select.js
+++ b/chrome/browser/resources/print_preview/settings/settings_section_select.js
@@ -18,7 +18,7 @@ cr.define('print_preview', function() {
/** @private {!print_preview.ticket_items.TicketItem} */
this.ticketItem_ = ticketItem;
- };
+ }
SettingsSectionSelect.prototype = {
__proto__: print_preview.SettingsSection.prototype,
@@ -89,7 +89,7 @@ cr.define('print_preview', function() {
}
// Try to select current ticket item.
var valueToSelect = JSON.stringify(this.ticketItem_.getValue());
- for (var i = 0, option; option = select.options[i]; i++) {
+ for (var i = 0, option; (option = select.options[i]); i++) {
if (option.value == valueToSelect) {
indexToSelect = i;
break;
« no previous file with comments | « chrome/browser/resources/print_preview/settings/settings_section.js ('k') | chrome/test/data/webui/print_preview.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698