Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: chrome/browser/resources/print_preview/settings/margin_settings.js

Issue 2861713004: Print Preview: Fix compile errors in settings/ directory (Closed)
Patch Set: Address comments and fix remaining lint errors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/margin_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/margin_settings.js b/chrome/browser/resources/print_preview/settings/margin_settings.js
index 2357ea8851c160f0071765551827ad6f840aaf5d..2d86be504a4ed5a4273a543afed805cb27b647d8 100644
--- a/chrome/browser/resources/print_preview/settings/margin_settings.js
+++ b/chrome/browser/resources/print_preview/settings/margin_settings.js
@@ -22,7 +22,7 @@ cr.define('print_preview', function() {
* @private
*/
this.marginsTypeTicketItem_ = marginsTypeTicketItem;
- };
+ }
/**
* CSS classes used by the margin settings component.
@@ -55,7 +55,7 @@ cr.define('print_preview', function() {
enterDocument: function() {
print_preview.SettingsSection.prototype.enterDocument.call(this);
this.tracker.add(
- this.select_, 'change', this.onSelectChange_.bind(this));
+ assert(this.select_), 'change', this.onSelectChange_.bind(this));
this.tracker.add(
this.marginsTypeTicketItem_,
print_preview.ticket_items.TicketItem.EventType.CHANGE,
@@ -79,7 +79,7 @@ cr.define('print_preview', function() {
onSelectChange_: function() {
var select = this.select_;
var marginsType =
- /** @type {!print_preview.ticket_items.MarginsType.Value} */ (
+ /** @type {!print_preview.ticket_items.MarginsTypeValue} */ (
select.selectedIndex);
this.marginsTypeTicketItem_.updateValue(marginsType);
},
@@ -92,9 +92,11 @@ cr.define('print_preview', function() {
onMarginsTypeTicketItemChange_: function() {
if (this.isAvailable()) {
var select = this.select_;
- var marginsType = this.marginsTypeTicketItem_.getValue();
+ var marginsType =
+ /** @type {!print_preview.ticket_items.MarginsTypeValue} */ (
+ this.marginsTypeTicketItem_.getValue());
var selectedMarginsType =
- /** @type {!print_preview.ticket_items.MarginsType.Value} */ (
+ /** @type {!print_preview.ticket_items.MarginsTypeValue} */ (
select.selectedIndex);
if (marginsType != selectedMarginsType) {
select.options[selectedMarginsType].selected = false;

Powered by Google App Engine
This is Rietveld 408576698