Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/browser/resources/print_preview/settings/layout_settings.js

Issue 2861713004: Print Preview: Fix compile errors in settings/ directory (Closed)
Patch Set: Address comments and fix remaining lint errors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/layout_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/layout_settings.js b/chrome/browser/resources/print_preview/settings/layout_settings.js
index af0bbeadf08fd55133f4c4a42d2df7711ea2512b..1113491b7dd9c0819f8231fb3c84c84996cbbbd4 100644
--- a/chrome/browser/resources/print_preview/settings/layout_settings.js
+++ b/chrome/browser/resources/print_preview/settings/layout_settings.js
@@ -22,7 +22,7 @@ cr.define('print_preview', function() {
* @private
*/
this.landscapeTicketItem_ = landscapeTicketItem;
- };
+ }
LayoutSettings.prototype = {
__proto__: print_preview.SettingsSection.prototype,
@@ -46,7 +46,7 @@ cr.define('print_preview', function() {
enterDocument: function() {
print_preview.SettingsSection.prototype.enterDocument.call(this);
this.tracker.add(
- this.select_, 'change', this.onSelectChange_.bind(this));
+ assert(this.select_), 'change', this.onSelectChange_.bind(this));
this.tracker.add(
this.landscapeTicketItem_,
print_preview.ticket_items.TicketItem.EventType.CHANGE,
@@ -70,7 +70,8 @@ cr.define('print_preview', function() {
* @private
*/
get select_() {
- return this.getChildElement('.layout-settings-select');
+ return /** @type {HTMLSelectElement} */(
+ this.getChildElement('.layout-settings-select'));
},
/**

Powered by Google App Engine
This is Rietveld 408576698