chrome/browser/resources/print_preview/settings/destination_settings.js - Issue 2861713004: Print Preview: Fix compile errors in settings/ directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/destination_settings.js

Issue 2861713004: Print Preview: Fix compile errors in settings/ directory (Closed)

Patch Set: Address comments and fix remaining lint errors Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/settings/copies_settings.js ('k') | chrome/browser/resources/print_preview/settings/dpi_settings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/destination_settings.js

diff --git a/chrome/browser/resources/print_preview/settings/destination_settings.js b/chrome/browser/resources/print_preview/settings/destination_settings.js

index d2a60d5be1ed2a0eabf27329676b58e3131c69b9..ff613d027f469571e907880041052c736c184353 100644

--- a/chrome/browser/resources/print_preview/settings/destination_settings.js

+++ b/chrome/browser/resources/print_preview/settings/destination_settings.js

@@ -32,7 +32,7 @@ cr.define('print_preview', function() {

* @private

this.iconClass_ = null;

- };

+ }

/**

* Event types dispatched by the component.

@@ -150,9 +150,9 @@ cr.define('print_preview', function() {

}

setIsVisible(

- this.getChildElement('.throbber-container'),

+ assert(this.getChildElement('.throbber-container')),

this.destinationStore_.isAutoSelectDestinationInProgress);

- setIsVisible(destinationSettingsBoxEl, !!destination);

+ setIsVisible(assert(destinationSettingsBoxEl), !!destination);

onSelectedDestinationNameSet_: function() {