Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: chrome/browser/resources/print_preview/settings/color_settings.js

Issue 2861713004: Print Preview: Fix compile errors in settings/ directory (Closed)
Patch Set: Address comments and fix remaining lint errors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/color_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/color_settings.js b/chrome/browser/resources/print_preview/settings/color_settings.js
index e1814f79bd6e584c123b6cb5f2a89c010f16a26a..5cc8562a9b83e1a876dd3f84e0d42ded6d1b7c3a 100644
--- a/chrome/browser/resources/print_preview/settings/color_settings.js
+++ b/chrome/browser/resources/print_preview/settings/color_settings.js
@@ -8,7 +8,7 @@ cr.define('print_preview', function() {
/**
* Creates a ColorSettings object. This object encapsulates all settings and
* logic related to color selection (color/bw).
- * @param {!print_preview.ticket_item.Color} colorTicketItem Used for writing
+ * @param {!print_preview.ticket_items.Color} colorTicketItem Used for writing
* and reading color value.
* @constructor
* @extends {print_preview.SettingsSection}
@@ -22,7 +22,7 @@ cr.define('print_preview', function() {
* @private
*/
this.colorTicketItem_ = colorTicketItem;
- };
+ }
ColorSettings.prototype = {
__proto__: print_preview.SettingsSection.prototype,
@@ -46,7 +46,7 @@ cr.define('print_preview', function() {
enterDocument: function() {
print_preview.SettingsSection.prototype.enterDocument.call(this);
this.tracker.add(
- this.select_, 'change', this.onSelectChange_.bind(this));
+ assert(this.select_), 'change', this.onSelectChange_.bind(this));
this.tracker.add(
this.colorTicketItem_,
print_preview.ticket_items.TicketItem.EventType.CHANGE,
@@ -69,7 +69,8 @@ cr.define('print_preview', function() {
* @private
*/
get select_() {
- return this.getChildElement('.color-settings-select');
+ return /** @type {HTMLSelectElement} */(
+ this.getChildElement('.color-settings-select'));
},
/**

Powered by Google App Engine
This is Rietveld 408576698