chrome/browser/resources/print_preview/previewarea/margin_control_container.js - Issue 2861713004: Print Preview: Fix compile errors in settings/ directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/previewarea/margin_control_container.js

Issue 2861713004: Print Preview: Fix compile errors in settings/ directory (Closed)

Patch Set: Address comments and fix remaining lint errors Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/preview_generator.js ('k') | chrome/browser/resources/print_preview/settings/advanced_options_settings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/previewarea/margin_control_container.js

diff --git a/chrome/browser/resources/print_preview/previewarea/margin_control_container.js b/chrome/browser/resources/print_preview/previewarea/margin_control_container.js

index 5615cddb93c7d6182efc9a9e785fa6a1494d46c8..d1341c65e02b0fe469db476116be3f367232c671 100644

--- a/chrome/browser/resources/print_preview/previewarea/margin_control_container.js

+++ b/chrome/browser/resources/print_preview/previewarea/margin_control_container.js

@@ -186,7 +186,7 @@ cr.define('print_preview', function() {

/** Shows the margin controls if the need to be shown. */

showMarginControlsIfNeeded: function() {

if (this.marginsTypeTicketItem_.getValue() ==

- print_preview.ticket_items.MarginsType.Value.CUSTOM) {

+ print_preview.ticket_items.MarginsTypeValue.CUSTOM) {

this.setIsMarginControlsVisible_(true);

}

@@ -381,7 +381,7 @@ cr.define('print_preview', function() {

}

if (this.marginsTypeTicketItem_.isCapabilityAvailable() &&

this.marginsTypeTicketItem_.getValue() ==

- print_preview.ticket_items.MarginsType.Value.CUSTOM) {

+ print_preview.ticket_items.MarginsTypeValue.CUSTOM) {

this.setIsMarginControlsVisible_(true);

}

@@ -429,7 +429,7 @@ cr.define('print_preview', function() {

}

this.updateClippingMask(this.clippingSize_);

if (this.marginsTypeTicketItem_.getValue() !=

- print_preview.ticket_items.MarginsType.Value.CUSTOM) {

+ print_preview.ticket_items.MarginsTypeValue.CUSTOM) {

this.setIsMarginControlsVisible_(false);

}