Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2666)

Unified Diff: chrome/browser/resources/print_preview/settings/advanced_options_settings.js

Issue 2861713004: Print Preview: Fix compile errors in settings/ directory (Closed)
Patch Set: Remove extra semis Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/advanced_options_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/advanced_options_settings.js b/chrome/browser/resources/print_preview/settings/advanced_options_settings.js
index e1284a749008675c20693907fa04844d0a27577e..54c1657c057edeac378dbab9292a44867e7d479b 100644
--- a/chrome/browser/resources/print_preview/settings/advanced_options_settings.js
+++ b/chrome/browser/resources/print_preview/settings/advanced_options_settings.js
@@ -7,7 +7,7 @@ cr.define('print_preview', function() {
/**
* Print options section to control printer advanced options.
- * @param {!print_preview.ticket_item.VendorItems} ticketItem Ticket item to
+ * @param {!print_preview.ticket_items.VendorItems} ticketItem Ticket item to
* check settings availability.
* @param {!print_preview.DestinationStore} destinationStore Used to determine
* the selected destination.
@@ -28,7 +28,7 @@ cr.define('print_preview', function() {
* @private {!print_preview.DestinationStore}
*/
this.destinationStore_ = destinationStore;
- };
+ }
/**
* Event types dispatched by the component.
@@ -61,7 +61,7 @@ cr.define('print_preview', function() {
print_preview.SettingsSection.prototype.enterDocument.call(this);
this.tracker.add(
- this.getButton_(), 'click', function() {
+ assert(this.getButton_()), 'click', function() {
dpapad 2017/05/04 01:20:04 Instead of asserting here, can we change getButton
rbpotter 2017/05/04 01:43:06 Done.
cr.dispatchSimpleEvent(
this, AdvancedOptionsSettings.EventType.BUTTON_ACTIVATED);
}.bind(this));

Powered by Google App Engine
This is Rietveld 408576698