chrome/browser/resources/print_preview/settings/margin_settings.html - Issue 2861713004: Print Preview: Fix compile errors in settings/ directory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/print_preview/settings/margin_settings.html

Issue 2861713004: Print Preview: Fix compile errors in settings/ directory (Closed)

Patch Set: Address comments and fix remaining lint errors Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <div id="margin-settings" class="two-column margin-settings" hidden>	1 <div id="margin-settings" class="two-column margin-settings" hidden>

2 <div class="left-column">	2 <div class="left-column">

3 <h1 id="margin-label">$i18n{marginsLabel}</h1>	3 <h1 id="margin-label">$i18n{marginsLabel}</h1>

4 </div>	4 </div>

5 <div class="right-column">	5 <div class="right-column">

6 <select class="margin-settings-select" aria-labelledby="margin-label">	6 <select class="margin-settings-select" aria-labelledby="margin-label">

7 <!-- The order of these options must match the natural order of their	7 <!-- The order of these options must match the natural order of their

8 values, which come from print_preview.ticket_items.MarginsType.Value. -->	8 values, which come from print_preview.ticket_items.MarginsTypeValue. -->

9 <option value="0" selected>$i18n{defaultMargins}</option>	9 <option value="0" selected>$i18n{defaultMargins}</option>

10 <option value="1">$i18n{noMargins}</option>	10 <option value="1">$i18n{noMargins}</option>

11 <option value="2">$i18n{minimumMargins}</option>	11 <option value="2">$i18n{minimumMargins}</option>

12 <option value="3">$i18n{customMargins}</option>	12 <option value="3">$i18n{customMargins}</option>

13 </select>	13 </select>

14 </div>	14 </div>

15 </div>	15 </div>

OLD	NEW