Print Preview: Fix compile errors in settings/ directory

chrome/browser/resources/print_preview/settings/advanced_options_settings.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Print options section to control printer advanced options.
-   * @param {!print_preview.ticket_item.VendorItems} ticketItem Ticket item to
+   * @param {!print_preview.ticket_items.VendorItems} ticketItem Ticket item to
    *     check settings availability.
    * @param {!print_preview.DestinationStore} destinationStore Used to determine
    *     the selected destination.
    * @constructor
    * @extends {print_preview.SettingsSection}
    */
   function AdvancedOptionsSettings(ticketItem, destinationStore) {
     print_preview.SettingsSection.call(this);
 
     /**
      * Ticket item to check settings availability.
      * @private {!print_preview.ticket_items.VendorItems}
      */
     this.ticketItem_ = ticketItem;
 
     /**
      * Used to determine the selected destination.
      * @private {!print_preview.DestinationStore}
      */
     this.destinationStore_ = destinationStore;
-  };
+  }
 
   /**
    * Event types dispatched by the component.
    * @enum {string}
    */
   AdvancedOptionsSettings.EventType = {
     BUTTON_ACTIVATED: 'print_preview.AdvancedOptionsSettings.BUTTON_ACTIVATED'
   };
 
   AdvancedOptionsSettings.prototype = {
@@ skipping 12 matching lines @@
     /** @param {boolean} isEnabled Whether the component is enabled. */
     set isEnabled(isEnabled) {
       this.getButton_().disabled = !isEnabled;
     },
 
     /** @override */
     enterDocument: function() {
       print_preview.SettingsSection.prototype.enterDocument.call(this);
 
       this.tracker.add(
-          this.getButton_(), 'click', function() {
+          assert(this.getButton_()), 'click', function() {

[dpapad, 2017/05/04 01:20:04]

Instead of asserting here, can we change getButton_() to return !HTMLElement and
assert there?

/**
 * @return {!HTMLElement}
 * @private
 */
getButton_: function() {
  return assert(this.getChildElement('.advanced-options-settings-button'));
},

Having said that, there is already wider TODO at
https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/c...
to make getCHildElement() return !HTMLElement, but probably better to do this
separately (if at all).

[rbpotter, 2017/05/04 01:43:06]

Done.

             cr.dispatchSimpleEvent(
                 this, AdvancedOptionsSettings.EventType.BUTTON_ACTIVATED);
           }.bind(this));
       this.tracker.add(
           this.destinationStore_,
           print_preview.DestinationStore.EventType.DESTINATION_SELECT,
           this.onDestinationChanged_.bind(this));
       this.tracker.add(
           this.destinationStore_,
           print_preview.DestinationStore.EventType.
@@ skipping 16 matching lines @@
     onDestinationChanged_: function() {
       this.updateUiStateInternal();
     }
   };
 
   // Export
   return {
     AdvancedOptionsSettings: AdvancedOptionsSettings
   };
 });