Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 2861673008: Add more text output to service test pause_on_start_then_step_test (Closed)

Created:
3 years, 7 months ago by jensj
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more text output to service test pause_on_start_then_step_test This test has timed out on the bots, but it isn't clear when exactly it 'stops responding'. This CL adds a few more lines of output in an attempt to make it more clear (on any new timeout) where it stops responding. See https://github.com/dart-lang/sdk/issues/29568 for example timeout. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/2074c4091915eb5cd8f4d13f26fa84663d9ad0a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M runtime/observatory/tests/service/pause_on_start_then_step_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jensj
3 years, 7 months ago (2017-05-05 13:36:03 UTC) #3
Kevin Millikin (Google)
It LGTM. I hope it helps.
3 years, 7 months ago (2017-05-05 16:07:57 UTC) #4
jensj
3 years, 7 months ago (2017-05-08 06:39:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2074c4091915eb5cd8f4d13f26fa84663d9ad0a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698