UMA for Mirror Feedback

UMA for New Profile Management Feedback

BUG=357693
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271027

[Mike Lerman, 2014-05-15 15:45:55]

Please reviewers, can I have a review?

Hui - Knowledge of ProfileChooserView
msw - owners on c/b/ui/views
Alexei - owner on histograms.xml

Thanks again!

[guohui, 2014-05-15 16:52:00]

lgtm

https://codereview.chromium.org/286163002/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

https://codereview.chromium.org/286163002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:96: // Used elected to send feedback.
nit: s/used/user/

same at line 94.

[Mike Lerman, 2014-05-15 17:23:18]

https://codereview.chromium.org/286163002/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_metrics.h (right):

https://codereview.chromium.org/286163002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_metrics.h:96: // Used elected to send feedback.
On 2014/05/15 16:52:01, guohui wrote:
> nit: s/used/user/
> 
> same at line 94.

Done.

[msw, 2014-05-15 17:30:58]

lgtm

[Alexei Svitkine (slow), 2014-05-15 17:34:09]

histograms lgtm

You might not want to use the Mirror codename in the CL description, since it's
a codename.

[Mike Lerman, 2014-05-15 17:40:16]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-05-15 17:43:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/286163002/20001

[commit-bot: I haz the power, 2014-05-15 21:15:47]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-15 21:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-15 21:21:09]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Mike Lerman, 2014-05-16 12:43:59]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-05-16 12:44:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/286163002/40001

[Mike Lerman, 2014-05-16 12:54:11]

The CQ bit was unchecked by mlerman@chromium.org

[Mike Lerman, 2014-05-16 12:55:00]

Hi Monica,

Can I get a quick review on this? profile_metrics.h

Thanks!

[noms (inactive), 2014-05-16 13:02:56]

profiles lgtm :)

[Mike Lerman, 2014-05-16 13:04:18]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-05-16 13:04:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/286163002/40001

[commit-bot: I haz the power, 2014-05-16 15:30:52]

Change committed as 271027