Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: cc/layers/surface_layer_impl_unittest.cc

Issue 2861593002: cc: Only add surface ID to embedded_surfaces if fallback does not match (Closed)
Patch Set: Updated Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/layers/surface_layer_impl.cc ('K') | « cc/layers/surface_layer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/surface_layer_impl_unittest.cc
diff --git a/cc/layers/surface_layer_impl_unittest.cc b/cc/layers/surface_layer_impl_unittest.cc
index 354972607003664456dde60d23ac37703485ab76..cca6a784ef301a1a34c5bad1293fcde5a8b3eb2c 100644
--- a/cc/layers/surface_layer_impl_unittest.cc
+++ b/cc/layers/surface_layer_impl_unittest.cc
@@ -292,7 +292,11 @@ TEST(SurfaceLayerImplTest,
std::unique_ptr<RenderPass> render_pass = RenderPass::Create();
AppendQuadsData data;
surface_layer_impl->AppendQuads(render_pass.get(), &data);
- EXPECT_THAT(data.embedded_surfaces, UnorderedElementsAre(surface_id1));
+ // SurfaceLayerImpl should not add a surface ID to the embedded_surfaces
+ // vector if it is also a fallback surface. The fallback surface will already
+ // be added as a reference in referenced_surfaces. Since the fallback is known
+ // to exist, then it isn't a dependency.
+ EXPECT_THAT(data.embedded_surfaces, testing::IsEmpty());
ASSERT_EQ(1u, render_pass->quad_list.size());
const SurfaceDrawQuad* surface_draw_quad1 =
« cc/layers/surface_layer_impl.cc ('K') | « cc/layers/surface_layer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698