[CrOS Tether] Open the Tether settings page when a tether notification body is clicked.

chrome/browser/chromeos/net/tether_notification_presenter.h

Index: chrome/browser/chromeos/net/tether_notification_presenter.h
diff --git a/chrome/browser/chromeos/net/tether_notification_presenter.h b/chrome/browser/chromeos/net/tether_notification_presenter.h
index 1110452cbbae51dd4845ebf68779d1a638b178ce..3de94688282eb0ae37f19c222039f9684686cdd1 100644
--- a/chrome/browser/chromeos/net/tether_notification_presenter.h
+++ b/chrome/browser/chromeos/net/tether_notification_presenter.h
@@ -18,6 +18,8 @@
 #include "ui/message_center/message_center_observer.h"
 #include "ui/message_center/notification.h"
 
+class Profile;
+
 namespace message_center {
 class MessageCenter;
 class Notification;
@@ -33,9 +35,10 @@ class TetherNotificationPresenter
     : public NotificationPresenter,
       public message_center::MessageCenterObserver {
  public:
-  // Caller must ensure that |message_center| amd |network_connect| outlive
-  // this instance.
-  TetherNotificationPresenter(message_center::MessageCenter* message_center,
+  // Caller must ensure that |profile|, |message_center|, and |network_connect|
+  // outlive this instance.
+  TetherNotificationPresenter(Profile* profile,
+                              message_center::MessageCenter* message_center,
                               NetworkConnect* network_connect);
   ~TetherNotificationPresenter() override;
 
@@ -53,8 +56,6 @@ class TetherNotificationPresenter
                                    int button_index) override;
 
  private:
-  friend class TetherNotificationPresenterTest;
-
   static const char kTetherNotifierId[];
   static const char kPotentialHotspotNotificationId[];
   static const char kActiveHostNotificationId[];
@@ -69,12 +70,27 @@ class TetherNotificationPresenter
       const base::string16& message,
       const message_center::RichNotificationData rich_notification_data);
 
+  friend class TetherNotificationPresenterTest;
+
+  class SettingsUiDelegate {
+   public:
+    SettingsUiDelegate();
+    virtual ~SettingsUiDelegate();

[stevenjb, 2017/05/03 23:07:44]

blank line and comment for ShowSettingsSubPageForProfile

[Kyle Horimoto, 2017/05/03 23:25:48]

Done.

+    virtual void ShowSettingsSubPageForProfile(Profile* profile,
+                                               const std::string& sub_page);

[stevenjb, 2017/05/03 23:07:44]

This should be a pure virtual. Create a local Impl class in the .cc file. Also
make the destructor protected.

[Kyle Horimoto, 2017/05/03 23:25:48]

Done, but I made the destructor public. Otherwise, I got a compiler error about
how unique_ptr can't delete it.

[stevenjb, 2017/05/03 23:42:37]

Acknowledged.

+  };
+
+  void SetSettingsUiDelegateForTesting(
+      std::unique_ptr<SettingsUiDelegate> settings_ui_delegate);

[stevenjb, 2017/05/03 23:07:44]

blank line

[Kyle Horimoto, 2017/05/03 23:25:48]

Done.

   void ShowNotification(
       std::unique_ptr<message_center::Notification> notification);
 
+  Profile* profile_;
   message_center::MessageCenter* message_center_;
   NetworkConnect* network_connect_;
 
+  std::unique_ptr<SettingsUiDelegate> settings_ui_delegate_;
+
   cryptauth::RemoteDevice hotspot_nearby_device_;
   base::WeakPtrFactory<TetherNotificationPresenter> weak_ptr_factory_;