Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: ui/views/window/dialog_client_view_unittest.cc

Issue 2861533003: Backfill some UI tests. (Closed)
Patch Set: fix silent merge conflict Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/test_render_view_host.cc ('k') | ui/views/window/dialog_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/window/dialog_client_view_unittest.cc
diff --git a/ui/views/window/dialog_client_view_unittest.cc b/ui/views/window/dialog_client_view_unittest.cc
index 877cdb8bb1054b3368dceaa3854e96b67203163d..bb8ec3647fdd6cf49ca65a1934b3cc2727ab9e95 100644
--- a/ui/views/window/dialog_client_view_unittest.cc
+++ b/ui/views/window/dialog_client_view_unittest.cc
@@ -420,4 +420,20 @@ TEST_F(DialogClientViewTest, LinkedWidths) {
EXPECT_EQ(20, boring_view->width());
}
+TEST_F(DialogClientViewTest, ButtonPosition) {
+ constexpr int button_row_inset = 13;
+ client_view()->SetButtonRowInsets(gfx::Insets(button_row_inset));
+ constexpr int contents_height = 37;
+ constexpr int contents_width = 222;
+ SetSizeConstraints(gfx::Size(), gfx::Size(contents_width, contents_height),
+ gfx::Size(666, 666));
+ SetDialogButtons(ui::DIALOG_BUTTON_OK);
+ client_view()->SizeToPreferredSize();
+ client_view()->Layout();
+ EXPECT_EQ(contents_width - button_row_inset,
+ client_view()->ok_button()->bounds().right());
+ EXPECT_EQ(contents_height + button_row_inset,
+ height() + client_view()->ok_button()->y());
+}
+
} // namespace views
« no previous file with comments | « content/test/test_render_view_host.cc ('k') | ui/views/window/dialog_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698