chrome/browser/ui/views/DEPS - Issue 2861533003: Backfill some UI tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/DEPS

Issue 2861533003: Backfill some UI tests. (Closed)

Patch Set: minor edits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+chrome/browser/ui/views",	2 "+chrome/browser/ui/views",

3 "+components/constrained_window",	3 "+components/constrained_window",

4 "+services/ui/public/cpp",	4 "+services/ui/public/cpp",

5 "+components/user_manager",	5 "+components/user_manager",

6 "+third_party/libaddressinput",	6 "+third_party/libaddressinput",

7 ]	7 ]

	8

	9 specific_include_rules = {

	10 # ValidationMessageBubbleView depends on RenderWidgetHostView directly, so the

	11 # unit test needs access to the test subclass.

	12 "validation_message_bubble_view_unittest.cc": [

	13 "+content/test/test_render_view_host.h",
	sky 2017/05/05 14:43:21 Code outside of content should only use code in co Code outside of content should only use code in content/public. Bret 2017/05/06 01:15:11 Changed the set_native_view call in RenderViewHost Show quoted text On 2017/05/05 14:43:21, sky wrote: > Code outside of content should only use code in content/public. Changed the set_native_view call in RenderViewHostTestHarness::SetUp, since TestRenderWidgetHostView needs root_window from aura::test::AuraTestHelper and I don't see any other way to get at it.
	14 ],

	15 }

OLD	NEW