Issue 286153003: Adds dynamic FEC on/off switch in packet creator. Tightens use of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 286153003: Adds dynamic FEC on/off switch in packet creator. Tightens use of (Closed)

Created:
6 years, 7 months ago by ramant (doing other things)

Modified:
6 years, 7 months ago

Reviewers:
Jana, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Jana

Base URL:
https://chromium.googlesource.com/chromium/src

Visibility:
Public.

More Reviews

Description

Adds dynamic FEC on/off switch in packet creator. Tightens use of max_packets_per_fec_group through use of a setter method across the QUIC code. FEC operations are now decided based on should_fec_protect_, which is expected to be a dynamic on/off control in the packet creator, instead of max_packets_per_fec_group. Adds dynamic FEC on/off switch in packet_creator. Merge internal change: 67144415 R=rch@chromium.org,jri@chromium.org

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+221 lines, -53 lines)			Patch
M	net/quic/quic_connection_test.cc	View	6 chunks	+14 lines, -6 lines	0 comments	Download
M	net/quic/quic_packet_creator.h	View	4 chunks	+31 lines, -8 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	11 chunks	+72 lines, -29 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	6 chunks	+84 lines, -6 lines	0 comments	Download
M	net/quic/quic_packet_generator_test.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	3 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages