Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2861523003: Add KernelXyzExpression stubs and factory methods. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add KernelXyzExpression stubs and factory methods. Some of the factories methods don't accept yet enough tokens, and fileOffset(s) for them are set externally. Also PropertyGet, SuperPropertySet, MethodInvocation which are used in accessors, are not converted yet. R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ec4c247efb1e742da7d5f73c863b05b4213d852d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+550 lines, -31 lines) Patch
M pkg/front_end/lib/src/fasta/builder/ast_factory.dart View 4 chunks +67 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 14 chunks +28 lines, -28 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_ast_factory.dart View 5 chunks +101 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 7 chunks +353 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
scheglov
3 years, 7 months ago (2017-05-03 03:57:12 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-03 15:26:23 UTC) #3
scheglov
3 years, 7 months ago (2017-05-03 15:50:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec4c247efb1e742da7d5f73c863b05b4213d852d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698