pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart - Issue 2861503002: fix #29530, field metadata generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart

Issue 2861503002: fix #29530, field metadata generation (Closed)

Patch Set: wip Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart b/pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart

index 8df816e173d082a46600849502fb860835541284..a5e272012403dcdcd91dfb913032e970e698f610 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart

@@ -541,8 +541,8 @@ class JsVariableMirror extends JsMirror implements VariableMirror {

: _symbol = symbol,

_name = getName(symbol),

type = reflectType(t),

- metadata =

- new List<InstanceMirror>.unmodifiable(annotations.map(reflect));

+ metadata = new List<InstanceMirror>.unmodifiable(

+ annotations?.map(reflect) ?? []);

JsVariableMirror._fromField(Symbol symbol, fieldInfo)

: this._(symbol, _wrap(JS('', '#.type', fieldInfo)),