Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2861503002: fix #29530, field metadata generation (Closed)

Created:
3 years, 7 months ago by Jennifer Messerly
Modified:
3 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -3 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A tests/lib_strong/mirrors/field_metadata2_test.dart View 1 1 chunk +26 lines, -0 lines 0 comments Download
A tests/lib_strong/mirrors/field_metadata_test.dart View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
3 years, 7 months ago (2017-05-02 21:41:22 UTC) #2
vsm
lgtm! https://codereview.chromium.org/2861503002/diff/1/tests/lib_strong/mirrors/field_metadata2_test.dart File tests/lib_strong/mirrors/field_metadata2_test.dart (right): https://codereview.chromium.org/2861503002/diff/1/tests/lib_strong/mirrors/field_metadata2_test.dart#newcode18 tests/lib_strong/mirrors/field_metadata2_test.dart:18: // Check that we can now relfect on ...
3 years, 7 months ago (2017-05-02 21:43:53 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/2861503002/diff/1/tests/lib_strong/mirrors/field_metadata2_test.dart File tests/lib_strong/mirrors/field_metadata2_test.dart (right): https://codereview.chromium.org/2861503002/diff/1/tests/lib_strong/mirrors/field_metadata2_test.dart#newcode18 tests/lib_strong/mirrors/field_metadata2_test.dart:18: // Check that we can now relfect on the ...
3 years, 7 months ago (2017-05-02 21:44:51 UTC) #4
Jennifer Messerly
3 years, 7 months ago (2017-05-02 21:45:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:10001) manually as
5e82b8c2e9d228f5e099e563060a6299cec9b336 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698