Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2861493002: Revert of Fix perfbotnot feature param setting from trial testing config.

Created:
3 years, 7 months ago by Alexei Svitkine (slow)
Modified:
3 years, 7 months ago
Reviewers:
perezju, jwd
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix perfbotnot feature param setting from trial testing config. (patchset #1 id:1 of https://codereview.chromium.org/2778313003/ ) Reason for revert: Creating revert CL for testing on perf try bots. (Not for landing.) DO NOT COMMIT Original issue's description: > Fix perfbotnot feature param setting from trial testing config. > > Previously, params that were queried via their associated features > would not get correctly picked by perfbots using the field trial > testing config. > > This was caused by the generated command-line not using the > --enable-features=FeatureName<TrialName syntax. This syntax is > needed in order to estable the link between a feature and its > associated trial, so that when a field-trial param is looked up > by feature, it's able to find it from the associated trial. > > Adds quotations to these params since "<" characters would > otherwise get interpreted by some shells. > > PERF SHERIFFS: This CL may cause perf bots to move - if so, it > means that one of the entries in the field trial testing config > that uses both params and features is causing the change but was > previously not being correctly tested. If so, we will need to > narrow down which one. > > BUG=706414 > > Review-Url: https://codereview.chromium.org/2778313003 > Cr-Commit-Position: refs/heads/master@{#460498} > Committed: https://chromium.googlesource.com/chromium/src/+/d47c7180be6c7531200d034d36c470fb5980f0e4 TBR=jwd@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=706414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M tools/variations/fieldtrial_util.py View 3 chunks +6 lines, -10 lines 0 comments Download
M tools/variations/fieldtrial_util_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Alexei Svitkine (slow)
3 years, 7 months ago (2017-05-02 21:29:48 UTC) #1
Created Revert of Fix perfbotnot feature param setting from trial testing
config.

Powered by Google App Engine
This is Rietveld 408576698