DescriptionRevert of Fix perfbotnot feature param setting from trial testing config. (patchset #1 id:1 of https://codereview.chromium.org/2778313003/ )
Reason for revert:
Creating revert CL for testing on perf try bots. (Not for landing.)
DO NOT COMMIT
Original issue's description:
> Fix perfbotnot feature param setting from trial testing config.
>
> Previously, params that were queried via their associated features
> would not get correctly picked by perfbots using the field trial
> testing config.
>
> This was caused by the generated command-line not using the
> --enable-features=FeatureName<TrialName syntax. This syntax is
> needed in order to estable the link between a feature and its
> associated trial, so that when a field-trial param is looked up
> by feature, it's able to find it from the associated trial.
>
> Adds quotations to these params since "<" characters would
> otherwise get interpreted by some shells.
>
> PERF SHERIFFS: This CL may cause perf bots to move - if so, it
> means that one of the entries in the field trial testing config
> that uses both params and features is causing the change but was
> previously not being correctly tested. If so, we will need to
> narrow down which one.
>
> BUG=706414
>
> Review-Url: https://codereview.chromium.org/2778313003
> Cr-Commit-Position: refs/heads/master@{#460498}
> Committed: https://chromium.googlesource.com/chromium/src/+/d47c7180be6c7531200d034d36c470fb5980f0e4
TBR=jwd@chromium.org,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=706414
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|