chrome/browser/resources/settings/downloads_page/downloads_page.js - Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/downloads_page/downloads_page.js

Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests (Closed)

Patch Set: Restore showPage_ Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/downloads_page/downloads_page.js

diff --git a/chrome/browser/resources/settings/downloads_page/downloads_page.js b/chrome/browser/resources/settings/downloads_page/downloads_page.js

index 76bb8d7108f79afdc8ad965476364d99e3b73729..23f5afb4b319efc2620fda60bfb886311712d432 100644

--- a/chrome/browser/resources/settings/downloads_page/downloads_page.js

+++ b/chrome/browser/resources/settings/downloads_page/downloads_page.js

@@ -56,6 +56,15 @@ Polymer({

this.browserProxy_.initializeDownloads();

+ /**

+ * @param {boolean|undefined} visibility

+ * @return {boolean}

+ * @private

+ */

+ showPage_: function(visibility) {

+ return visibility !== false;

+ },

/** @private */

selectDownloadLocation_: function() {

listenOnce(this, 'transitionend', function() {