chrome/browser/resources/settings/basic_page/basic_page.js - Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests (Closed)

Patch Set: Restore showPage_ Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/basic_page/basic_page.js

diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js

index 4032ade5091d750830b47e9b0c096be08ad0edb6..169d9c3906be5111560c256b2f3a8e2bccbcbc97 100644

--- a/chrome/browser/resources/settings/basic_page/basic_page.js

+++ b/chrome/browser/resources/settings/basic_page/basic_page.js

@@ -142,11 +142,12 @@ Polymer({

/**

+ * @param {!PageVisibility} visibility

* @param {string} subpage

* @return {!Object}

- getPageVisibility_: function(subpage) {

- return /** @type {Object} */ (this.get(subpage, this.pageVisibility)) || {};

+ getPageVisibility_: function(visibility, subpage) {

+ return /** @type {Object} */ (this.get(subpage, visibility)) || {};

// <if expr="chromeos">