chrome/browser/resources/settings/appearance_page/appearance_page.js - Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests (Closed)

Patch Set: Restore showPage_ Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/appearance_page/appearance_page.html ('k') | chrome/browser/resources/settings/basic_page/basic_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/appearance_page/appearance_page.js

diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js

index 289e20bdbd4ebc0240bbd7e127c20579ecd8e3af..72841dadcb23f1375e7e1f67e00ed2831aff664c 100644

--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js

+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js

@@ -144,6 +144,15 @@ Polymer({

/**

+ * @param {boolean|undefined} visibility

+ * @return {boolean}

+ * @private

+ */

+ showPage_: function(visibility) {

+ return visibility !== false;

+ },

+ /**

* @param {number} zoom

* @return {number} A zoom easier read by users.

* @private