MD Settings: Fix subpage visibility and add appearance page tests

chrome/browser/resources/settings/basic_page/basic_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-basic-page' is the settings page containing the actual settings.
  */
 Polymer({
   is: 'settings-basic-page',
@@ skipping 124 matching lines @@
   /**
    * @param {boolean|undefined} visibility
    * @return {boolean}
    * @private
    */
   showPage_: function(visibility) {
     return visibility !== false;
   },
 
   /**
+   * @param {!PageVisibility} visibility
    * @param {string} subpage
    * @return {!Object}
    */
-  getPageVisibility_: function(subpage) {
-    return /** @type {Object} */ (this.get(subpage, this.pageVisibility)) || {};
+  getPageVisibility_: function(visibility, subpage) {
+    return /** @type {Object} */ (this.get(subpage, visibility)) || {};
   },
 
 // <if expr="chromeos">
   /**
    * @return {boolean}
    * @private
    */
   computeShowSecondaryUserBanner_: function() {
     return !this.hasExpandedSection_ &&
         loadTimeData.getBoolean('isSecondaryUser');
@@ skipping 65 matching lines @@
 
   /**
    * @param {boolean} opened Whether the menu is expanded.
    * @return {string} Icon name.
    * @private
    */
   getArrowIcon_: function(opened) {
     return opened ? 'cr:arrow-drop-up' : 'cr:arrow-drop-down';
   },
 });