Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests (Closed)
Patch Set: Restore showPage_ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-privacy-page' is the settings page containing privacy and 7 * 'settings-privacy-page' is the settings page containing privacy and
8 * security settings. 8 * security settings.
9 */ 9 */
10 (function() { 10 (function() {
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 this.browserProxy_.getSafeBrowsingExtendedReporting().then(setSber); 143 this.browserProxy_.getSafeBrowsingExtendedReporting().then(setSber);
144 }, 144 },
145 145
146 /** @protected */ 146 /** @protected */
147 currentRouteChanged: function() { 147 currentRouteChanged: function() {
148 this.showClearBrowsingDataDialog_ = 148 this.showClearBrowsingDataDialog_ =
149 settings.getCurrentRoute() == settings.Route.CLEAR_BROWSER_DATA; 149 settings.getCurrentRoute() == settings.Route.CLEAR_BROWSER_DATA;
150 }, 150 },
151 151
152 /** 152 /**
153 * @param {boolean|undefined} visibility
154 * @return {boolean}
155 * @private
156 */
157 showPage_: function(visibility) {
158 return visibility !== false;
159 },
160
161 /**
153 * @param {Event} event 162 * @param {Event} event
154 * @private 163 * @private
155 */ 164 */
156 onDoNotTrackDomChange_: function(event) { 165 onDoNotTrackDomChange_: function(event) {
157 if (this.showDoNotTrackDialog_) 166 if (this.showDoNotTrackDialog_)
158 this.maybeShowDoNotTrackDialog_(); 167 this.maybeShowDoNotTrackDialog_();
159 }, 168 },
160 169
161 /** 170 /**
162 * Handles the change event for the do-not-track toggle. Shows a 171 * Handles the change event for the do-not-track toggle. Shows a
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 : this.i18n('siteSettingsBlocked'); 337 : this.i18n('siteSettingsBlocked');
329 }, 338 },
330 339
331 /** @private */ 340 /** @private */
332 getProtectedContentIdentifiersLabel_: function(value) { 341 getProtectedContentIdentifiersLabel_: function(value) {
333 return value ? this.i18n('siteSettingsProtectedContentEnableIdentifiers') 342 return value ? this.i18n('siteSettingsProtectedContentEnableIdentifiers')
334 : this.i18n('siteSettingsBlocked'); 343 : this.i18n('siteSettingsBlocked');
335 }, 344 },
336 }); 345 });
337 })(); 346 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698