MD Settings: Fix subpage visibility and add appearance page tests

chrome/test/data/webui/settings/appearance_page_test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {settings.AppearanceBrowserProxy}
  * @extends {settings.TestBrowserProxy}
  */
 var TestAppearanceBrowserProxy = function() {
@@ skipping 92 matching lines @@
       theme: {
         id: {
           value: '',
         },
         use_system: {
           value: false,
         },
       },
     },
   });
+  appearancePage.set('pageVisibility', {});
 
   document.body.appendChild(appearancePage);
   Polymer.dom.flush();
 }
 
+suite('AppearancePageVisibility', function() {
+  setup(function() {
+    appearanceBrowserProxy = new TestAppearanceBrowserProxy();
+    settings.AppearanceBrowserProxyImpl.instance_ = appearanceBrowserProxy;
+    createAppearancePage();
+  });
+
+  teardown(function() {
+    appearancePage.remove();
+  });
+
+  if (cr.isChromeOS) {
+    test('setWallpaper', function() {
+      assertTrue(!!appearancePage.$$('#setWallpaper'));
+    });
+  } else {
+    test('noSetWallpaper', function() {
+      assertTrue(!appearancePage.$$('#setWallpaper'));
+    });
+  }
+
+  test('setTheme', function() {
+    assertTrue(!!appearancePage.$$('#setTheme'));
+  });
+
+  test('homeButton', function() {
+    assertTrue(!!appearancePage.$$('#homeButton'));

[dpapad, 2017/05/04 01:03:24]

Now that we don't use dom-if, these tests are insufficient (they check existence
which is always true, and therefore did not catch the problem mentioned in
previous comment).

+  });
+
+  test('bookmarksBar', function() {
+    assertTrue(!!appearancePage.$$('#bookmarksBar'));
+  });
+});
+
 suite('AppearanceHandler', function() {
   setup(function() {
     appearanceBrowserProxy = new TestAppearanceBrowserProxy();
     settings.AppearanceBrowserProxyImpl.instance_ = appearanceBrowserProxy;
     createAppearancePage();
   });
 
   teardown(function() { appearancePage.remove(); });
 
   if (cr.isChromeOS) {
     test('wallpaperManager', function() {
-      var button = appearancePage.$.wallpaperButton;
+      var button = appearancePage.$$('#setWallpaper');
       assertTrue(!!button);
       MockInteractions.tap(button);
       return appearanceBrowserProxy.whenCalled('openWallpaperManager');
     });
   } else {
     test('noWallpaperManager', function() {
       // The wallpaper button should not be present.
-      var button = appearancePage.$.wallpaperButton;
+      var button = appearancePage.$$('#setWallpaper');
       assertFalse(!!button);
     });
   }
 
   var THEME_ID_PREF = 'prefs.extensions.theme.id.value';
 
   if (cr.isLinux && !cr.isChromeOS) {
     var USE_SYSTEM_PREF = 'prefs.extensions.theme.use_system.value';
 
     test('useDefaultThemeLinux', function() {
@@ skipping 60 matching lines @@
       var button = appearancePage.$$('#useDefault');
       assertTrue(!!button);
 
       MockInteractions.tap(button);
       return appearanceBrowserProxy.whenCalled('useDefaultTheme');
     });
   }
 
   test('default zoom handling', function() {
     function getDefaultZoomText() {
-      var zoomLevel = appearancePage.$.zoomLevel;
+      var zoomLevel = appearancePage.$$('#zoomLevel');
       return zoomLevel.options[zoomLevel.selectedIndex].textContent.trim();
     }
 
     return appearanceBrowserProxy.whenCalled('getDefaultZoom').then(function() {
       assertEquals('100%', getDefaultZoomText());
 
       appearanceBrowserProxy.setDefaultZoom(2 / 3);
       createAppearancePage();
       return appearanceBrowserProxy.whenCalled('getDefaultZoom');
     }).then(function() {
@@ skipping 53 matching lines @@
           Polymer.dom.flush();
           assertEquals(homeUrlInput.value, '@@@');  // Value hasn't changed.
           assertTrue(homeUrlInput.invalid);
 
           // Should reset to default value on change event.
           homeUrlInput.$.input.fire('change');
           Polymer.dom.flush();
           assertEquals(homeUrlInput.value, 'test');
         });
   });
-});
+});