[PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts

chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc

Index: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..18b39e58e38d09050e847255172e4f153d370043
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
@@ -0,0 +1,31 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/test/browser_test.h"
+#include "net/test/embedded_test_server/embedded_test_server.h"
+
+class AdsPageLoadMetricsObserverBrowserTest : public InProcessBrowserTest {
+ public:
+  AdsPageLoadMetricsObserverBrowserTest() {}
+  ~AdsPageLoadMetricsObserverBrowserTest() override {}
+
+  void SetUpOnMainThread() override {
+    ASSERT_TRUE(embedded_test_server()->Start());

[Charlie Harrison, 2017/05/04 20:21:14]

#include gtest

[jkarlin, 2017/05/05 19:56:28]

Done.

+    InProcessBrowserTest::SetUpOnMainThread();
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AdsPageLoadMetricsObserverBrowserTest);

[Charlie Harrison, 2017/05/04 20:21:14]

#include base/macros

[jkarlin, 2017/05/05 19:56:28]

Done.

+};
+
+IN_PROC_BROWSER_TEST_F(AdsPageLoadMetricsObserverBrowserTest,
+                       DocOverwritesNavigation) {
+  // Test that a subframe that aborts (due to doc.write) doesn't cause a crash

[Charlie Harrison, 2017/05/04 20:21:14]

optional: I prefer comments above test names.

[jkarlin, 2017/05/05 19:56:28]

Done.

+  // if it continues to load resources.
+  ui_test_utils::NavigateToURL(

[Charlie Harrison, 2017/05/04 20:21:14]

#include gurl

[jkarlin, 2017/05/05 19:56:28]

Done.

+      browser(), embedded_test_server()->GetURL(
+                     "/ads_observer/docwrite_provisional_frame.html"));
+}