chrome/test/data/ads_observer/docwrite_provisional_frame.html - Issue 2861433005: [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/ads_observer/docwrite_provisional_frame.html

Issue 2861433005: [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts (Closed)

Patch Set: Fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <iframe id="slow_frame" src="slow?100"></iframe>

	3

	4 <script>

	5 // slow takes 100 seconds to load, plenty of time to overwrite the

	6 // provisional load.

	7 let iframe = document.getElementById("slow_frame");

	8 let doc = iframe.contentDocument;

	9

	10 doc.open();

	11 doc.write('<html>Rewritten. <img src=pixel.png><img src=pixel2.png><img src=pi xel3.png></html>');
	Charlie Harrison 2017/05/04 20:21:14 Can you confirm that the images are successfully l Can you confirm that the images are successfully loaded? I know it makes the test more complicated but I am only vaguely sure that this even works. My suggestion is to use document.write to write something like: <img src="pixel.png" onload="postMessage('loaded');" Then in the parent use a message listener + domAutomationController to send a signal to the test harness. jkarlin 2017/05/05 19:56:28 Sure. Done. Show quoted text On 2017/05/04 20:21:14, Charlie Harrison wrote: > Can you confirm that the images are successfully loaded? I know it makes the > test more complicated but I am only vaguely sure that this even works. > > My suggestion is to use document.write to write something like: > <img src="pixel.png" onload="postMessage('loaded');" > > Then in the parent use a message listener + domAutomationController to send a > signal to the test harness. Sure. Done.
	12 doc.close();

	13 </script>

	14

	15 </html>

OLD	NEW