Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 286143010: Remove knowledge of nacl from content. (Closed)

Created:
6 years, 7 months ago by bradn
Modified:
6 years, 7 months ago
Reviewers:
sehr, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove knowledge of nacl from content. Content should not have knowledge of NaCl. Moving per process NaCl debug stub port information to NaClBrowser. More explicitly distiquish between the case where the debug port is not yet known versus when it is unused. Switch debug port to being a per-process value (as it is). This relands r270907 with a fix to make it work with disable_nacl=1 and therefore ASAN. BUG=None TEST=trybots R=jam@chromium.org,sehr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -63 lines) Patch
M chrome/browser/task_manager/child_process_resource_provider.cc View 5 chunks +3 lines, -13 lines 0 comments Download
M chrome/browser/task_manager/resource_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/resource_provider.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/task_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 7 chunks +27 lines, -9 lines 0 comments Download
M components/nacl/browser/nacl_browser.h View 4 chunks +12 lines, -2 lines 0 comments Download
M components/nacl/browser/nacl_browser.cc View 3 chunks +21 lines, -9 lines 0 comments Download
M components/nacl/browser/nacl_process_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M content/browser/browser_child_process_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/browser/browser_child_process_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/child_process_data.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bradn
jam + sehr, PTAL. My previous change, got reverted due to it not building under ...
6 years, 7 months ago (2014-05-16 18:39:39 UTC) #1
jam
lgtm
6 years, 7 months ago (2014-05-16 18:41:42 UTC) #2
sehr
lgtm
6 years, 7 months ago (2014-05-16 19:52:52 UTC) #3
bradn
The CQ bit was checked by bradnelson@google.com
6 years, 7 months ago (2014-05-16 19:54:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/286143010/1
6 years, 7 months ago (2014-05-16 19:54:43 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 01:03:26 UTC) #6
Message was sent while issue was closed.
Change committed as 271133

Powered by Google App Engine
This is Rietveld 408576698