Make AX update layout on all frames

Make AX update layout on all frames

When updating layout before exploring the AX tree, do it on
all frames. Relax the assertion in WebAXObject::boundingBoxRect
so that it's okay if the lifecycle is StyleClean and needsLayout() is false.

Also a bit of cleanup - the name "backing store", inherited from WebKit,
doesn't make sense in this context - changed it to be more clear.

BUG=374275
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174407

[dglazkov, 2014-05-16 17:08:55]

+esprehn

[esprehn, 2014-05-16 17:13:41]

This isn't right, what is calling into boundingBoxRect() without calling
updateLayout() first? That should update the layout on all ancestor frames and
yourself.

The bug here seems to be that something is calling boundingBoxRect() without
doing layout.

[dmazzoni, 2014-05-16 17:19:11]

Thanks for the explanation. We were calling updateLayout on the top document,
but since the accessibility tree spans frames that was leading to this assertion
failure. I'll send a correct fix.

[dmazzoni, 2014-05-16 21:25:02]

I updated the change and the description. Ready for a fresh look.

[esprehn, 2014-05-19 22:13:18]

lgtm, but that ASSERT needs to be more strict.

https://codereview.chromium.org/286143008/diff/40001/Source/web/WebAXObject.cpp
File Source/web/WebAXObject.cpp (right):

https://codereview.chromium.org/286143008/diff/40001/Source/web/WebAXObject.c...
Source/web/WebAXObject.cpp:553: || (document->lifecycle().state() >=
DocumentLifecycle::StyleClean && !document->view()->needsLayout());
This isn't correct, InPreLayout is >= StyleClean, but layout is not clean there.
We just haven't done the recalcStyle yet that would dirty it.

I'd suggest doing == StyleClean if possible

[dmazzoni, 2014-05-20 18:33:52]

https://codereview.chromium.org/286143008/diff/40001/Source/web/WebAXObject.cpp
File Source/web/WebAXObject.cpp (right):

https://codereview.chromium.org/286143008/diff/40001/Source/web/WebAXObject.c...
Source/web/WebAXObject.cpp:553: || (document->lifecycle().state() >=
DocumentLifecycle::StyleClean && !document->view()->needsLayout());
On 2014/05/19 22:13:19, esprehn wrote:
> This isn't correct, InPreLayout is >= StyleClean, but layout is not clean
there.
> We just haven't done the recalcStyle yet that would dirty it.
> 
> I'd suggest doing == StyleClean if possible

Done: == StyleClean works.

[dglazkov, 2014-05-20 18:35:11]

lgtm

[dmazzoni, 2014-05-20 18:36:10]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-05-20 18:36:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/286143008/50001

[commit-bot: I haz the power, 2014-05-20 20:07:09]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/8406)

[commit-bot: I haz the power, 2014-05-20 21:06:59]

Change committed as 174407