Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: ui/android/view_android_unittests.cc

Issue 2861413002: Refined DCHECK preventing multiple event forwarders in VA tree path (Closed)
Patch Set: comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/android/view_android.cc ('K') | « ui/android/view_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/view_android_unittests.cc
diff --git a/ui/android/view_android_unittests.cc b/ui/android/view_android_unittests.cc
index 77c9bcae16534428660684bb80c2c99af788a641..95ce3c25994165995e24cadee52c11fbee2d171b 100644
--- a/ui/android/view_android_unittests.cc
+++ b/ui/android/view_android_unittests.cc
@@ -166,4 +166,30 @@ TEST_F(ViewAndroidBoundsTest, MatchesViewsWithOffset) {
ExpectHit(client3_);
}
+TEST(ViewAndroidTest, ChecksMultipleEventForwarders) {
+ ViewAndroid parent;
+ ViewAndroid child;
+ parent.GetEventForwarder();
+ child.GetEventForwarder();
+ EXPECT_DEATH(parent.AddChild(&child), "Check failed:");
+
+ ViewAndroid window;
+ ViewAndroid wcv1, wcv2;
+ ViewAndroid rwhv1a, rwhv1b, rwhv2;
+ wcv1.GetEventForwarder();
+ wcv1.GetEventForwarder();
+
+ window.AddChild(&wcv1);
+ wcv1.AddChild(&rwhv1a);
+ wcv1.AddChild(&rwhv1b);
+ wcv2.AddChild(&rwhv2);
+
+ // window can add wcv2 since there's only one event forwarder at wcv2
+ // in the path window - wcv2 - rwvh2
+ window.AddChild(&wcv2);
+
+ // Both wcv1 & rwhv1 have event forwarders in the path window - wcv1 - rwhv1a.
+ EXPECT_DEATH(rwhv1a.GetEventForwarder(), "Check failed:");
+}
+
} // namespace ui
« ui/android/view_android.cc ('K') | « ui/android/view_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698