Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: ui/android/view_android.h

Issue 2861413002: Refined DCHECK preventing multiple event forwarders in VA tree path (Closed)
Patch Set: comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/android/view_android.cc » ('j') | ui/android/view_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/view_android.h
diff --git a/ui/android/view_android.h b/ui/android/view_android.h
index fbd3c452cd1bfc555b5e50c828b7d4f2ad255c22..5d41ebecae4b77eb2e2fca4726e39550db69d939 100644
--- a/ui/android/view_android.h
+++ b/ui/android/view_android.h
@@ -178,11 +178,9 @@ class UI_ANDROID_EXPORT ViewAndroid {
bool has_event_forwarder() const { return !!event_forwarder_; }
- // Returns true if any node of the tree along the hierarchy (view's children
- // and parents) already has |EventForwarder| attached to it.
- static bool ViewTreeHasEventForwarder(ViewAndroid* view);
-
- // Returns true if any children node (or self) has |EventForwarder|.
+ // Checks if there is any event forwarder in any parent nodes,
+ // or in the node paths down to each leaf of subtree.
boliu 2017/05/10 23:55:13 two methods, two comments
Jinsuk Kim 2017/05/11 00:17:14 Done.
+ static bool RootPathHasEventForwarder(ViewAndroid* parent);
static bool SubtreeHasEventForwarder(ViewAndroid* view);
// Returns the Java delegate for this view. This is used to delegate work
« no previous file with comments | « no previous file | ui/android/view_android.cc » ('j') | ui/android/view_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698