Improve default support provided for plugins

Improve default support provided for plugins

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/9ca84e15f4f5c70dfd810900c5b783180a84cb4c

[Brian Wilkerson, 2017-05-08 16:39:46]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-05-08 16:45:43]

LGTM

https://codereview.chromium.org/2861373005/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2861373005/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:212: for (ContextRoot contextRoot in
roots) {
Do we want to handle this as "reanalyze contexts" or "recreate contexts for
previously set analysis roots"? Because in general the might be different number
of contexts now, e.g. the user added some pubspec.yaml files.

[Brian Wilkerson, 2017-05-08 17:01:10]

https://codereview.chromium.org/2861373005/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2861373005/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:212: for (ContextRoot contextRoot in
roots) {
Interesting question. My intuition is that (a) changes that alter the context
structure are fairly rare and (b) we'll get watch events for those changes. That
implies to me that it will generally be faster to not re-do the work of finding
context roots most of the time. WDYT?

[Brian Wilkerson, 2017-05-08 17:01:39]

Description was changed from

==========
Improve default support provided for plugins
==========

to

==========
Improve default support provided for plugins

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9ca84e15f4f5c70dfd810900c5b783180a84cb4c
==========

[Brian Wilkerson, 2017-05-08 17:01:40]

Committed patchset #1 (id:1) manually as
9ca84e15f4f5c70dfd810900c5b783180a84cb4c (presubmit successful).