Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2861363002: [infra] Make gclient runhooks gn for Android on supported platforms (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
Bill Hesse, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[infra] Make gclient runhooks gn for Android on supported platforms Make GN run for Android configurations on supported host platforms on a gclient runhooks. This should fix the vm-precomp-android-* bots Committed: https://github.com/dart-lang/sdk/commit/7fb361907ba83d2ee2ed295c6dc500235b875670

Patch Set 1 #

Patch Set 2 : Update generate_buildfiles.py #

Patch Set 3 : Better fix for Android #

Patch Set 4 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/generate_buildfiles.py View 1 2 3 3 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
zra
TBR
3 years, 7 months ago (2017-05-07 06:52:12 UTC) #3
zra
3 years, 7 months ago (2017-05-07 06:52:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7fb361907ba83d2ee2ed295c6dc500235b875670 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698