Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2861223004: Adds new metric to distinguish between no address and no recent address. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index d7463c886a18fba95c0f1c156db5a7f0d552b4bb..09b315ba6ca8ab9379599d2341eece47bf685053 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -107,29 +107,32 @@ class AutofillMetrics {
INVALID_CVC_VALUE = 1 << 3,
// A CVC was detected but no recently created or used address was available.
// We don't know whether we would have been able to get upload details.
- UPLOAD_NOT_OFFERED_NO_ADDRESS = 1 << 4,
+ UPLOAD_NOT_OFFERED_NO_RECENTLY_USED_ADDRESS = 1 << 4,
+ // A CVC was detected but no address was available.
Jared Saul 2017/05/05 22:17:50 "A CVC was detected but..." isn't strictly true be
csashi 2017/05/05 22:42:27 Done.
+ // We don't know whether we would have been able to get upload details.
+ UPLOAD_NOT_OFFERED_NO_ADDRESS = 1 << 5,
// A CVC and one or more addresses were available but no name was found on
// either the card or the address(es). We don't know whether the address(es)
// were otherwise valid nor whether we would have been able to get upload
// details.
- UPLOAD_NOT_OFFERED_NO_NAME = 1 << 5,
+ UPLOAD_NOT_OFFERED_NO_NAME = 1 << 6,
// A CVC, multiple addresses, and a name were available but the addresses
// had
// conflicting zip codes. We don't know whether we would have been able to
// get upload details.
- UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS = 1 << 6,
+ UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS = 1 << 7,
// A CVC, one or more addresses, and a name were available but no zip code
// was found on any of the address(es). We don't know whether we would have
// been able to get upload details.
- UPLOAD_NOT_OFFERED_NO_ZIP_CODE = 1 << 7,
+ UPLOAD_NOT_OFFERED_NO_ZIP_CODE = 1 << 8,
// A CVC and one or more addresses were available but the names on the card
// and/or the addresses didn't match. We don't know whether the address(es)
// were otherwise valid nor whether we would have been able to get upload
// details.
- UPLOAD_NOT_OFFERED_CONFLICTING_NAMES = 1 << 8,
+ UPLOAD_NOT_OFFERED_CONFLICTING_NAMES = 1 << 9,
// A CVC, one or more valid addresses, and a name were available but the
// request to Payments for upload details failed.
- UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED = 1 << 9,
+ UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED = 1 << 10,
// Update |kNumCardUploadDecisionMetrics| when adding new enum here.
};
@@ -888,7 +891,7 @@ class AutofillMetrics {
};
private:
- static const int kNumCardUploadDecisionMetrics = 10;
+ static const int kNumCardUploadDecisionMetrics = 11;
DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics);
};

Powered by Google App Engine
This is Rietveld 408576698