Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: services/service_manager/embedder/main.cc

Issue 2861163002: Linux: Disable DBus auto-launch (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/service_manager/embedder/main.cc
diff --git a/services/service_manager/embedder/main.cc b/services/service_manager/embedder/main.cc
index 9635dc2c514bdd43a2ca02535d06d901dfe11f31..77f4eb3eaa71e9d2ed3e0604570fb13896a8c071 100644
--- a/services/service_manager/embedder/main.cc
+++ b/services/service_manager/embedder/main.cc
@@ -338,6 +338,19 @@ int Main(const MainParams& params) {
#endif
base::EnableTerminationOnOutOfMemory();
+#if defined(OS_LINUX)
+ // The various desktop environments set this environment variable that allows
+ // the dbus client library to connect directly to the bus. When this variable
+ // is not set (test environments like xvfb-run), the dbus client library will
+ // fall back to auto-launch mode. Auto-launch is dangerous as it can cause
+ // hangs (crbug.com/715658) . This one line disables the dbus auto-launch,
+ // by clobbering the DBUS_SESSION_BUS_ADDRESS env variable if not already set.
+ // The old auto-launch behavior, if needed, can be restored by setting
+ // DBUS_SESSION_BUS_ADDRESS="autolaunch:" before launching chrome.
+ const int kNoOverrideIfAlreadySet = 0;
+ setenv("DBUS_SESSION_BUS_ADDRESS", "disabled:", kNoOverrideIfAlreadySet);
satorux1 2017/05/08 01:30:37 Several environmental variables, such as GNOME_DIS
+#endif
+
#if defined(OS_WIN)
base::win::RegisterInvalidParamHandler();
ui::win::CreateATLModuleIfNeeded();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698